qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/qtest: Fix STM32L4x5 SYSCFG irq line 15 state assumpti


From: Peter Maydell
Subject: Re: [PATCH] tests/qtest: Fix STM32L4x5 SYSCFG irq line 15 state assumption
Date: Mon, 1 Jul 2024 12:45:42 +0100

On Sat, 29 Jun 2024 at 11:46, Inès Varhol <ines.varhol@telecom-paris.fr> wrote:
>
> The QTest `test_irq_pin_multiplexer` makes the assumption that the
> reset state of irq line 15 is low, which is false since STM32L4x5 GPIO
> was implemented (the reset state of pin GPIOA15 is high because there's
> pull-up and it results in the irq line 15 also being high at reset).
>
> It wasn't triggering an error because `test_interrupt` was mistakenly
> "resetting" the line low.
>
> This commit corrects these two mistakes by :
> - not setting the line low in `test_interrupt`
> - using an irq line in `test_irq_pin_multiplexer` which is low at reset
>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---



Applied to target-arm.next, thanks.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]