Re: [PATCH 1/2] system/vl.c: do not allow mixed -accel opts

[Daniel Henrique Barboza]

On 7/1/24 12:23 PM, Richard Henderson wrote:
> On 7/1/24 06:30, Daniel Henrique Barboza wrote:
> > We're allowing multiple -accel options to be used with different
> > accelerators, even though we don't have any machine that supports mixed
> > acceleration.
> >
> > In fact, it will only parse the first occurence of -accel and, aside
> > from a help option (e.g. -accel help) that will always cause the process
> > to print the help text, it will accept every other accel option
> > regardless of being correct or not. E.g. this:
> >
> > qemu-system-x86_64 -accel kvm -accel tcg -accel IamNotAnAccel (...)
> >
> > will happily boot a x86_64 KVM guest.
> >
> > Do not allow for different accelerators to be used when multiple
> > instances of -accel are present.
> >
> > Cc: Paolo Bonzini<pbonzini@redhat.com>
> > Cc: Thomas Huth<thuth@redhat.com>
> > Signed-off-by: Daniel Henrique Barboza<dbarboza@ventanamicro.com>
> > ---
> >   system/vl.c | 15 ++++++++++++++-
> >   1 file changed, 14 insertions(+), 1 deletion(-)
>
> We use '-accel kvm -accel tcg' to allow kvm to fail (e.g. no /dev/kvm 
> permission) and proceed with tcg.
>
> This patch will cause testsuite failures.

For the issue I want to fix patch 2 alone is enough. I'll re-send.


Thanks,

Daniel


> r~