[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 31/67] hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 31/67] hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name() |
Date: |
Tue, 2 Jul 2024 11:20:14 +0200 |
In order to access SDState::SDProto from sd_[a]cmd_name(),
pass SDState as argument.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-38-philmd@linaro.org>
---
hw/sd/sd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 90bb47ad26..5b356f0be8 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -230,7 +230,7 @@ static const char *sd_response_name(sd_rsp_type_t rsp)
return response_name[rsp];
}
-static const char *sd_cmd_name(uint8_t cmd)
+static const char *sd_cmd_name(SDState *sd, uint8_t cmd)
{
static const char *cmd_abbrev[SDMMC_CMD_MAX] = {
[0] = "GO_IDLE_STATE", [1] = "SEND_OP_COND",
@@ -269,7 +269,7 @@ static const char *sd_cmd_name(uint8_t cmd)
return cmd_abbrev[cmd] ? cmd_abbrev[cmd] : "UNKNOWN_CMD";
}
-static const char *sd_acmd_name(uint8_t cmd)
+static const char *sd_acmd_name(SDState *sd, uint8_t cmd)
{
static const char *acmd_abbrev[SDMMC_CMD_MAX] = {
[6] = "SET_BUS_WIDTH",
@@ -1273,7 +1273,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
uint64_t addr;
uint32_t data;
- sd->last_cmd_name = sd_cmd_name(req.cmd);
+ sd->last_cmd_name = sd_cmd_name(sd, req.cmd);
/* CMD55 precedes an ACMD, so we are not interested in tracing it.
* However there is no ACMD55, so we want to trace this particular case.
*/
@@ -1740,7 +1740,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
static sd_rsp_type_t sd_app_command(SDState *sd,
SDRequest req)
{
- sd->last_cmd_name = sd_acmd_name(req.cmd);
+ sd->last_cmd_name = sd_acmd_name(sd, req.cmd);
trace_sdcard_app_command(sd->proto->name, sd->last_cmd_name,
req.cmd, req.arg, sd_state_name(sd->state));
sd->card_status |= APP_CMD;
--
2.41.0
- [PULL 21/67] hw/sd/sdcard: Convert SD_STATUS to generic_read_byte (ACMD13), (continued)
- [PULL 21/67] hw/sd/sdcard: Convert SD_STATUS to generic_read_byte (ACMD13), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 22/67] hw/sd/sdcard: Convert SEND_NUM_WR_BLOCKS to generic_read_byte (ACMD22), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 23/67] hw/sd/sdcard: Convert SEND_SCR to generic_read_byte (ACMD51), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 24/67] hw/sd/sdcard: Introduce sd_cmd_to_receivingdata / sd_generic_write_byte, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 25/67] hw/sd/sdcard: Duplicate WRITE_SINGLE_BLOCK / WRITE_MULTIPLE_BLOCK cases, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 26/67] hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 27/67] hw/sd/sdcard: Convert PROGRAM_CID to generic_write_byte (CMD26), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 28/67] hw/sd/sdcard: Convert PROGRAM_CSD to generic_write_byte (CMD27), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 29/67] hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 30/67] hw/sd/sdcard: Move sd_[a]cmd_name() methods to sd.c, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 31/67] hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name(),
Philippe Mathieu-Daudé <=
- [PULL 32/67] hw/sd/sdcard: Prepare SDProto to contain more fields, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 33/67] hw/sd/sdcard: Store command name in SDProto, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 34/67] hw/sd/sdcard: Store command type in SDProto, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 36/67] hw/sd/sdcard: Remove SEND_DSR dead case (CMD4), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 35/67] hw/sd/sdcard: Store command class in SDProto, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 38/67] hw/sd/sdcard: Register optional handlers from spec v6.00, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 41/67] hw/sd/sdcard: Add sd_cmd_SWITCH_FUNCTION handler (CMD6), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 37/67] hw/sd/sdcard: Register generic optional handlers (CMD11 and CMD20), Philippe Mathieu-Daudé, 2024/07/02
- [PULL 40/67] hw/sd/sdcard: Register Security Extension optional handlers, Philippe Mathieu-Daudé, 2024/07/02
- [PULL 39/67] hw/sd/sdcard: Register SDIO optional handlers, Philippe Mathieu-Daudé, 2024/07/02