Re: [PATCH v3 10/15] docs/interop/firmware.json: Add igvm to FirmwareDevice

[Roy Hopkins]

On Thu, 2024-06-27 at 14:53 +0200, Stefano Garzarella wrote:
> On Fri, Jun 21, 2024 at 03:29:13PM GMT, Roy Hopkins wrote:
> > Create an enum entry within FirmwareDevice for 'igvm' to describe that
> > an IGVM file can be used to map firmware into memory as an alternative
> > to pre-existing firmware devices.
> > 
> > Signed-off-by: Roy Hopkins <roy.hopkins@suse.com>
> > ---
> > docs/interop/firmware.json | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> > index 54a1fc6c10..9a9178606e 100644
> > --- a/docs/interop/firmware.json
> > +++ b/docs/interop/firmware.json
> > @@ -55,10 +55,17 @@
> > #
> > # @memory: The firmware is to be mapped into memory.
> > #
> > +# @igvm: The firmware is defined by a file conforming to the IGVM
> > +#        specification and mapped into memory according to directives
> > +#        defined in the file. This is similar to @memory but may
> > +#        include additional processing defined by the IGVM file
> > +#        including initial CPU state or population of metadata into
> > +#        the guest address space.
> 
> Should we add (Since: 9.1) ?
> 
> I'm not sure about that, since I don't see it used much in docs/interop/
> 
> Thanks,
> Stefano
> 

I'll add it to the end of the @igvm description. Thanks.

> > +#
> > # Since: 3.0
> > ##
> > { 'enum' : 'FirmwareDevice',
> > -  'data' : [ 'flash', 'kernel', 'memory' ] }
> > +  'data' : [ 'flash', 'kernel', 'memory', 'igvm' ] }
> > 
> > ##
> > # @FirmwareTarget:
> > -- 
> > 2.43.0
> > 
>