Re: [PATCH 1/4] hw/sd/npcm7xx_sdhci: Use TYPE_SYSBUS_SDHCI definition

[Cédric Le Goater]

On 7/2/24 4:08 PM, Philippe Mathieu-Daudé wrote:
> Use the macro instead of two explicit string literals.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/sd/npcm7xx_sdhci.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sd/npcm7xx_sdhci.c b/hw/sd/npcm7xx_sdhci.c
> index e93dab8dbd..fb51821e11 100644
> --- a/hw/sd/npcm7xx_sdhci.c
> +++ b/hw/sd/npcm7xx_sdhci.c
> @@ -16,6 +16,7 @@
>   
>   #include "qemu/osdep.h"
>   
> +#include "hw/sd/sdhci.h"
>   #include "hw/sd/npcm7xx_sdhci.h"
>   #include "migration/vmstate.h"
>   #include "sdhci-internal.h"
> @@ -162,7 +163,7 @@ static void npcm7xx_sdhci_instance_init(Object *obj)
>   {
>       NPCM7xxSDHCIState *s = NPCM7XX_SDHCI(obj);
>   
> -    object_initialize_child(OBJECT(s), "generic-sdhci", &s->sdhci,
> +    object_initialize_child(OBJECT(s), TYPE_SYSBUS_SDHCI, &s->sdhci,
>                               TYPE_SYSBUS_SDHCI);
>   }
>