|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v2 05/22] qga: move linux disk/cpu stats command impls to commands-linux.c |
Date: | Wed, 3 Jul 2024 10:25:19 +0200 |
User-agent: | Mozilla Thunderbird |
On 13/6/24 17:01, Daniel P. Berrangé wrote:
The qmp_guest_{diskstats,cpustats} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c This also removes a "#ifdef CONFIG_LINUX" that was nested inside a "#ifdef __linux__". Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- qga/commands-linux.c | 195 ++++++++++++++++++++++++++++++++++++++++++ qga/commands-posix.c | 199 ------------------------------------------- 2 files changed, 195 insertions(+), 199 deletions(-)
Easy to review using 'git-diff --color-moved=dimmed-zebra'. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[Prev in Thread] | Current Thread | [Next in Thread] |