Re: [PATCH v2 19/22] qga: move declare of QGAConfig struct to top of file

[Philippe Mathieu-Daudé]

On 13/6/24 17:44, Daniel P. Berrangé wrote:
> It is referenced by QGAState already, and it is clearer to declare all
> data types at the top of the file, rather than have them mixed with
> code later.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   qga/main.c | 44 ++++++++++++++++++++++----------------------
>   1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 17b6ce18ac..647d27037c 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -70,6 +70,28 @@ typedef struct GAPersistentState {
>   
>   typedef struct GAConfig GAConfig;

Matter of style, personally I'd squash within the
typedef.

> +struct GAConfig {
> +    char *channel_path;
> +    char *method;
> +    char *log_filepath;
> +    char *pid_filepath;
> +#ifdef CONFIG_FSFREEZE
> +    char *fsfreeze_hook;
> +#endif
> +    char *state_dir;
> +#ifdef _WIN32
> +    const char *service;
> +#endif
> +    gchar *bliststr; /* blockedrpcs may point to this string */
> +    gchar *aliststr; /* allowedrpcs may point to this string */
> +    GList *blockedrpcs;
> +    GList *allowedrpcs;
> +    int daemonize;
> +    GLogLevelFlags log_level;
> +    int dumpconf;
> +    bool retry_path;
> +};

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>