Re: [PATCH v46 3/5] hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler

[Cédric Le Goater]

On 7/3/24 3:43 PM, Philippe Mathieu-Daudé wrote:
> The correct command name is 'SD SEND_OP_COND',
> rename accordingly.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/sd/sd.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 04e8fdb262..10f2764a53 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1701,7 +1701,7 @@ static sd_rsp_type_t 
> sd_acmd_SET_WR_BLK_ERASE_COUNT(SDState *sd, SDRequest req)
>   }
>   
>   /* ACMD41 */
> -static sd_rsp_type_t sd_acmd_SD_APP_OP_COND(SDState *sd, SDRequest req)
> +static sd_rsp_type_t sd_cmd_SEND_OP_COND(SDState *sd, SDRequest req)
>   {
>       if (sd->state != sd_idle_state) {
>           return sd_invalid_state_for_cmd(sd, req);
> @@ -2378,7 +2378,7 @@ static const SDProto sd_proto_sd = {
>           [13] = {8,  sd_adtc, "SD_STATUS", sd_acmd_SD_STATUS},
>           [22] = {8,  sd_adtc, "SEND_NUM_WR_BLOCKS", 
> sd_acmd_SEND_NUM_WR_BLOCKS},
>           [23] = {8,  sd_ac,   "SET_WR_BLK_ERASE_COUNT", 
> sd_acmd_SET_WR_BLK_ERASE_COUNT},
> -        [41] = {8,  sd_bcr,  "SD_APP_OP_COND", sd_acmd_SD_APP_OP_COND},
> +        [41] = {8,  sd_bcr,  "SEND_OP_COND", sd_cmd_SEND_OP_COND},
>           [42] = {8,  sd_ac,   "SET_CLR_CARD_DETECT", 
> sd_acmd_SET_CLR_CARD_DETECT},
>           [51] = {8,  sd_adtc, "SEND_SCR", sd_acmd_SEND_SCR},
>       },