[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v3 10/85] vhost-vsock: add VIRTIO_F_RING_PACKED to feature_bits
From: |
Michael S. Tsirkin |
Subject: |
[PULL v3 10/85] vhost-vsock: add VIRTIO_F_RING_PACKED to feature_bits |
Date: |
Wed, 3 Jul 2024 18:45:00 -0400 |
From: Halil Pasic <pasic@linux.ibm.com>
Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the
vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED
but the in QEMU device is configured to try to use the packed layout
(the virtio property "packed" is on).
As of today, the Linux kernel vhost-vsock device does not support the
packed queue layout (as vhost does not support packed), and does not
offer VIRTIO_F_RING_PACKED. Thus when for example a vhost-vsock-ccw is
used with packed=on, VIRTIO_F_RING_PACKED ends up being negotiated,
despite the fact that the device does not actually support it, and
one gets to keep the pieces.
Fixes: 74b3e46630 ("virtio: add property to enable packed virtqueue")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Message-Id: <20240429113334.2454197-1-pasic@linux.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/vhost-vsock-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/vhost-vsock-common.c b/hw/virtio/vhost-vsock-common.c
index 12ea87d7a7..fd88df2560 100644
--- a/hw/virtio/vhost-vsock-common.c
+++ b/hw/virtio/vhost-vsock-common.c
@@ -22,6 +22,7 @@
const int feature_bits[] = {
VIRTIO_VSOCK_F_SEQPACKET,
VIRTIO_F_RING_RESET,
+ VIRTIO_F_RING_PACKED,
VHOST_INVALID_FEATURE_BIT
};
--
MST
- [PULL v3 00/85] virtio: features,fixes, Michael S. Tsirkin, 2024/07/03
- [PULL v3 01/85] vhost: dirty log should be per backend type, Michael S. Tsirkin, 2024/07/03
- [PULL v3 02/85] vhost: Perform memory section dirty scans once per iteration, Michael S. Tsirkin, 2024/07/03
- [PULL v3 03/85] vhost-vdpa: check vhost_vdpa_set_vring_ready() return value, Michael S. Tsirkin, 2024/07/03
- [PULL v3 04/85] virtio/virtio-pci: Handle extra notification data, Michael S. Tsirkin, 2024/07/03
- [PULL v3 05/85] virtio: Prevent creation of device using notification-data with ioeventfd, Michael S. Tsirkin, 2024/07/03
- [PULL v3 06/85] virtio-mmio: Handle extra notification data, Michael S. Tsirkin, 2024/07/03
- [PULL v3 08/85] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits, Michael S. Tsirkin, 2024/07/03
- [PULL v3 09/85] Fix vhost user assertion when sending more than one fd, Michael S. Tsirkin, 2024/07/03
- [PULL v3 10/85] vhost-vsock: add VIRTIO_F_RING_PACKED to feature_bits,
Michael S. Tsirkin <=
- [PULL v3 07/85] virtio-ccw: Handle extra notification data, Michael S. Tsirkin, 2024/07/03
- [PULL v3 11/85] hw/virtio: Fix obtain the buffer id from the last descriptor, Michael S. Tsirkin, 2024/07/03
- [PULL v3 13/85] vhost-user-gpu: fix import of DMABUF, Michael S. Tsirkin, 2024/07/03
- [PULL v3 12/85] virtio-pci: only reset pm state during resetting, Michael S. Tsirkin, 2024/07/03
- [PULL v3 14/85] Revert "vhost-user: fix lost reconnect", Michael S. Tsirkin, 2024/07/03
- [PULL v3 15/85] vhost-user: fix lost reconnect again, Michael S. Tsirkin, 2024/07/03
- [PULL v3 18/85] hw/cxl/cxl-mailbox-utils: Add dc_event_log_size field to output payload of identify memory device command, Michael S. Tsirkin, 2024/07/03
- [PULL v3 16/85] hw/cxl/mailbox: change CCI cmd set structure to be a member, not a reference, Michael S. Tsirkin, 2024/07/03
- [PULL v3 19/85] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support, Michael S. Tsirkin, 2024/07/03
- [PULL v3 17/85] hw/cxl/mailbox: interface to add CCI commands to an existing CCI, Michael S. Tsirkin, 2024/07/03