qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 6/7] tests/plugin/mem: add option to print memory accesses


From: Pierrick Bouvier
Subject: Re: [PATCH v4 6/7] tests/plugin/mem: add option to print memory accesses
Date: Thu, 4 Jul 2024 16:29:32 -0700
User-agent: Mozilla Thunderbird

On 7/4/24 09:30, Richard Henderson wrote:
On 7/2/24 11:44, Pierrick Bouvier wrote:
+    case QEMU_PLUGIN_MEM_VALUE_U128:
+        g_string_append_printf(out, "0x%.0"PRIx64"%"PRIx64,
+                               value.data.u128.high, value.data.u128.low);

PRIx64 does not pad.
You need %016"PRIx64 for the low value.


Oops, indeed. I'll output all values with fixed width.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]