Re: [PATCH v2 0/4] ui/cocoa: Add cursor composition

[Phil Dennis-Jordan]

On Thu, 27 Jun 2024 at 13:17, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:

Add accelerated cursor composition to ui/cocoa. This does not only
improve performance for display devices that exposes the capability to
the guest according to dpy_cursor_define_supported(), but fixes the
cursor display for devices that unconditionally expects the availability
of the capability (e.g., virtio-gpu).

The common pattern to implement accelerated cursor composition is to
replace the cursor and warp it so that the replaced cursor is shown at
the correct position on the guest display for relative pointer devices.
Unfortunately, ui/cocoa cannot do the same because warping the cursor
position interfers with the mouse input so it uses CALayer instead;
although it is not specialized for cursor composition, it still can
compose images with hardware acceleration.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

 

After fixing the typo in patch 3/4, the code appears to work as intended. (Tested on macOS 13 & 14, virtio-gpu with Cocoa UI.)

So, for the whole patch set:

Tested-by: Phil Dennis-Jordan <phil@philjordan.eu>