[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/7] plugins: fix mem callback array size
From: |
Alex Bennée |
Subject: |
Re: [PATCH v6 1/7] plugins: fix mem callback array size |
Date: |
Mon, 08 Jul 2024 10:27:05 +0100 |
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> data was correctly copied, but size of array was not set
> (g_array_sized_new only reserves memory, but does not set size).
>
> As a result, callbacks were not called for code path relying on
> plugin_register_vcpu_mem_cb().
>
> Found when trying to trigger mem access callbacks for atomic
> instructions.
>
> Reviewed-by: Xingtao Yao <yaoxt.fnst@fujitsu.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- [PATCH v6 0/7] plugins: access values during a memory read/write, Pierrick Bouvier, 2024/07/06
- [PATCH v6 1/7] plugins: fix mem callback array size, Pierrick Bouvier, 2024/07/06
- [PATCH v6 2/7] plugins: save value during memory accesses, Pierrick Bouvier, 2024/07/06
- [PATCH v6 3/7] plugins: extend API to get latest memory value accessed, Pierrick Bouvier, 2024/07/06
- [PATCH v6 5/7] tests/tcg: allow to check output of plugins, Pierrick Bouvier, 2024/07/06
- [PATCH v6 6/7] tests/plugin/mem: add option to print memory accesses, Pierrick Bouvier, 2024/07/06
- [PATCH v6 7/7] tests/tcg/x86_64: add test for plugin memory access, Pierrick Bouvier, 2024/07/06