Re: [PATCH V13 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

[Igor Mammedov]

On Mon, 8 Jul 2024 05:32:28 +0000
Salil Mehta <salil.mehta@opnsrc.net> wrote:

> On 06/07/2024 14:45, Igor Mammedov wrote:
> > On Fri, 7 Jun 2024 12:56:49 +0100
> > Salil Mehta <salil.mehta@huawei.com> wrote:
> >  
> >> GED interface is used by many hotplug events like memory hotplug, NVDIMM 
> >> hotplug
> >> and non-hotplug events like system power down event. Each of these can be
> >> selected using a bit in the 32 bit GED IO interface. A bit has been 
> >> reserved for
> >> the CPU hotplug event.
> >>
> >> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> >> Reviewed-by: Gavin Shan <gshan@redhat.com>
> >> Tested-by: Zhao Liu <zhao1.liu@intel.com>  
> > suggest to squash this into the patch that introduces this bit [3/8]  
> 
> I thought, we are introducing a change common to all architectures?

hw reduced hotplug implies GED, so including doc change
into the patch that introduces bit in the code is better
option.

it also easier on the folks that come later and find doc
and code in the same commit (which is easier to follow
than looking for different commits in git log).

> > Best, Salil.
> 
> >> ---
> >>   docs/specs/acpi_hw_reduced_hotplug.rst | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/docs/specs/acpi_hw_reduced_hotplug.rst 
> >> b/docs/specs/acpi_hw_reduced_hotplug.rst
> >> index 0bd3f9399f..3acd6fcd8b 100644
> >> --- a/docs/specs/acpi_hw_reduced_hotplug.rst
> >> +++ b/docs/specs/acpi_hw_reduced_hotplug.rst
> >> @@ -64,7 +64,8 @@ GED IO interface (4 byte access)
> >>          0: Memory hotplug event
> >>          1: System power down event
> >>          2: NVDIMM hotplug event
> >> -    3-31: Reserved
> >> +       3: CPU hotplug event
> >> +    4-31: Reserved
> >>   
> >>   **write_access:**
> >>     
> > :
> >  
>