[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] docs/qapidoc: factor out do_parse()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 1/8] docs/qapidoc: factor out do_parse() |
Date: |
Tue, 09 Jul 2024 12:28:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
John Snow <jsnow@redhat.com> writes:
> On Sat, Jul 6, 2024, 10:47 AM Markus Armbruster <armbru@redhat.com> wrote:
>
>> John Snow <jsnow@redhat.com> writes:
>>
>> > Factor out the compatibility parser helper into a base class, so it can
>> > be shared by other directives.
>> >
>> > Signed-off-by: John Snow <jsnow@redhat.com>
>>
>> R-by stands.
>
> Assuming true even if I rebase on top of the 3.x patches and do_parse()
> becomes quite a bit more trivial?
If you think the changes don't warrant a fresh review, keep my R-by.
You may get one anyway ;)
- [PATCH 0/8] qapi: convert example sections to qmp-example rST directives, John Snow, 2024/07/03
- [PATCH 1/8] docs/qapidoc: factor out do_parse(), John Snow, 2024/07/03
- [PATCH 2/8] docs/qapidoc: create qmp-example directive, John Snow, 2024/07/03
- [PATCH 3/8] docs/qapidoc: add QMP highlighting to annotated qmp-example blocks, John Snow, 2024/07/03
- [PATCH 4/8] docs/sphinx: add CSS styling for qmp-example directive, John Snow, 2024/07/03
- [PATCH 5/8] qapi: convert "Example" sections without titles, John Snow, 2024/07/03