Re: [PATCH v2 0/4] Reconstruct loongson ipi driver

[maobibo]

Hi Philippe/Jiaxun,

Could you do me a favor giving a review about this patch?

Regards
Bibo Mao

On 2024/7/4 上午11:37, Bibo Mao wrote:
> Now loongson ipi and loongarch ipi share the same code with different
> macro, loongson ipi has its separate function such mmio region,
> loongarch ipi has other requirement such as irqchip in kernel.
>
> Interrupt irqchip has strong relationship with architecture, since
> it sends irq to vcpu and interfaces to get irqchip register is also
> architecture specific.
>
> Here like other architectures, base class TYPE_LOONGSON_IPI_COMMON
> is added, it comes from loongson ipi mostly. And it defined four abstract
> interfaces which can be used for MIPS 3A4000 and Loongarch 3A5000 machine,
> also can be used for 3A5000 irqchip in kernel mode soon.
>
> Also Loongarch ipi and loongson ipi device are added here, it inherits
> from base class TYPE_LOONGSON_IPI_COMMON. Loongarch ipi is tested,
> loongson ipi device only passes to compile and make check, it is not
> tested.
>
> Bibo Mao (4):
>    hw/intc/loongson_ipi_common: Add loongson ipi common class
>    hw/intc/loongarch_ipi: Add loongarch ipi support
>    hw/loongarch/virt: Replace loongson ipi with loongarch ipi
>    hw/intc/loongson_ipi: reconstruct driver inherit from common class
>
>   hw/intc/Kconfig                       |   3 +
>   hw/intc/loongarch_ipi.c               |  80 ++++++
>   hw/intc/loongson_ipi.c                | 330 ++-------------------
>   hw/intc/loongson_ipi_common.c         | 394 ++++++++++++++++++++++++++
>   hw/intc/meson.build                   |   3 +-
>   hw/loongarch/Kconfig                  |   2 +-
>   hw/loongarch/virt.c                   |   4 +-
>   include/hw/intc/loongarch_ipi.h       |  33 +++
>   include/hw/intc/loongson_ipi.h        |  54 ++--
>   include/hw/intc/loongson_ipi_common.h |  77 +++++
>   include/hw/loongarch/virt.h           |   1 -
>   11 files changed, 632 insertions(+), 349 deletions(-)
>   create mode 100644 hw/intc/loongarch_ipi.c
>   create mode 100644 hw/intc/loongson_ipi_common.c
>   create mode 100644 include/hw/intc/loongarch_ipi.h
>   create mode 100644 include/hw/intc/loongson_ipi_common.h
>
>
> base-commit: 6746482d12da3b6e4d3cdf06481a0027a797f719