[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V1 7/8] vfio: vfio_find_ram_discard_listener
From: |
Steve Sistare |
Subject: |
[PATCH V1 7/8] vfio: vfio_find_ram_discard_listener |
Date: |
Tue, 9 Jul 2024 13:58:56 -0700 |
Define vfio_find_ram_discard_listener as a subroutine so additional calls to
it may be added in a subsequent patch.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
hw/vfio/common.c | 35 ++++++++++++++++++++++-------------
1 file changed, 22 insertions(+), 13 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 72a692a..5c7baad 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -561,6 +561,26 @@ static bool vfio_get_section_iova_range(VFIOContainerBase
*bcontainer,
return true;
}
+static VFIORamDiscardListener *vfio_find_ram_discard_listener(
+ VFIOContainerBase *bcontainer, MemoryRegionSection *section)
+{
+ VFIORamDiscardListener *vrdl = NULL;
+
+ QLIST_FOREACH(vrdl, &bcontainer->vrdl_list, next) {
+ if (vrdl->mr == section->mr &&
+ vrdl->offset_within_address_space ==
+ section->offset_within_address_space) {
+ break;
+ }
+ }
+
+ if (!vrdl) {
+ hw_error("vfio: Trying to sync missing RAM discard listener");
+ /* does not return */
+ }
+ return vrdl;
+}
+
static void vfio_listener_region_add(MemoryListener *listener,
MemoryRegionSection *section)
{
@@ -1285,19 +1305,8 @@
vfio_sync_ram_discard_listener_dirty_bitmap(VFIOContainerBase *bcontainer,
MemoryRegionSection *section)
{
RamDiscardManager *rdm =
memory_region_get_ram_discard_manager(section->mr);
- VFIORamDiscardListener *vrdl = NULL;
-
- QLIST_FOREACH(vrdl, &bcontainer->vrdl_list, next) {
- if (vrdl->mr == section->mr &&
- vrdl->offset_within_address_space ==
- section->offset_within_address_space) {
- break;
- }
- }
-
- if (!vrdl) {
- hw_error("vfio: Trying to sync missing RAM discard listener");
- }
+ VFIORamDiscardListener *vrdl =
+ vfio_find_ram_discard_listener(bcontainer, section);
/*
* We only want/can synchronize the bitmap for actually mapped parts -
--
1.8.3.1
- [PATCH V1 0/8] Live update: vfio, Steve Sistare, 2024/07/09
- [PATCH V1 2/8] pci: export msix_is_pending, Steve Sistare, 2024/07/09
- [PATCH V1 3/8] vfio-pci: refactor for cpr, Steve Sistare, 2024/07/09
- [PATCH V1 8/8] vfio-pci: recover from unmap-all-vaddr failure, Steve Sistare, 2024/07/09
- [PATCH V1 7/8] vfio: vfio_find_ram_discard_listener,
Steve Sistare <=
- [PATCH V1 6/8] vfio-pci: cpr part 3 (intx), Steve Sistare, 2024/07/09
- [PATCH V1 1/8] migration: cpr_needed_for_reuse, Steve Sistare, 2024/07/09
- [PATCH V1 4/8] vfio-pci: cpr part 1 (fd and dma), Steve Sistare, 2024/07/09
- [PATCH V1 5/8] vfio-pci: cpr part 2 (msi), Steve Sistare, 2024/07/09