Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

[Philippe Mathieu-Daudé]

On 9/7/24 17:58, Cédric Le Goater wrote:
> On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote:
> > Since v42:
> > - Stick to spec v4.3 (re-simplified EXT_CSD register & migrate)
> > - Fill CID register
> > - Few changes to CSD register
> > - Implement 'boot-mode' reset timing
> > - Add 'boot-size' property
> >
> > Change required for aspeed branch:
> > -- >8 --
> > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> > index 8c0e36badd..563816b710 100644
> > --- a/hw/arm/aspeed.c
> > +++ b/hw/arm/aspeed.c
> > @@ -344,3 +344,3 @@ static void sdhci_attach_drive(SDHCIState *sdhci, 
> > DriveInfo *dinfo, bool emmc,
> >           if (emmc) {
> > -            qdev_prop_set_uint8(card, "boot-config", boot_emmc ? 0x48 
> > : 0x0);
> > +            qdev_prop_set_uint64(card, "boot-size", 1 * MiB);
> >           }
> > (I'm still reluctant to merge patches 16-18)...
>
> Then, please drop all changes related to the boot partitions. I will keep
> the original patches in my tree and address the feature when I have time.
> TYPE_EMMC is already great to have.

As you mentioned on today's community call, eMMC is a chipset soldered
on a board, so our boards exactly knows what size to expect on the card,
and whether boot partitions are present or not. I find the way of
building the drive image described in patch #16 cumbersome, but I'm OK
to make some concession on it, since "it works" as it. If necessary
we'll improve and deprecate the current properties. I'll repost and
plan to merge as-is (modulo review comments).

Regards,

Phil.