Re: [PATCH v2 06/13] target/ppc: Hoist dcbz_size out of dcbz_common

[Richard Henderson]

On 7/10/24 05:11, BALATON Zoltan wrote:
> On Tue, 9 Jul 2024, Richard Henderson wrote:
> > The 970 logic does not apply to dcbzep, which is an e500 insn.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> As all callers pass GETPC() to retaddr maybe that could be moved into dcbz_common() as i 
> had in my patch.

No, that would be incorrect usage of GETPC.
It *must* be used in the HELPER directly called from TCG.


r~