On Thu, Jul 11, 2024 at 3:53 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
On 2024/07/10 17:02, hellord wrote:
>
> note:
> 1. The path of buggy msvcrt.dll is c:\windows\system32\msvcrt.dll(
> mingw64 links to it );
> 2. fwrite implementation in another msvc library which is called
> ucrtbase.dll is correct(msvc links to it by default).
I don't object to this change but you should use ucrt whenever possible.
I'm not confident that elf2dmp and other QEMU binaries would work well
with mvcrt.
I even would like to force users to use ucrt and call setlocale(LC_ALL,
".UTF8") to fix text encoding, but I haven't done that yet because
Fedora, which cross-compiles QEMU for CI, still uses msvcrt.
Thanks.
Using ucrt by default (or mandatorily) is a good point, helps avoid other unknown bugs in msvcrt and is
beneficial for the long-term development of QEMU on Windows.