qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] backup: add minimum cluster size to performance optio


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v3 2/2] backup: add minimum cluster size to performance options
Date: Fri, 12 Jul 2024 15:56:48 +0300
User-agent: Mozilla Thunderbird

On 11.07.24 15:09, Fiona Ebner wrote:
In the context of backup fleecing, discarding the source will not work
when the fleecing image has a larger granularity than the one used for
block-copy operations (can happen if the backup target has smaller
cluster size), because cbw_co_pdiscard_snapshot() will align down the
discard requests and thus effectively ignore then.

To make @discard-source work in such a scenario, allow specifying the
minimum cluster size used for block-copy operations and thus in
particular also the granularity for discard requests to the source.

Suggested-by: Vladimir Sementsov-Ogievskiy<vsementsov@yandex-team.ru>
Acked-by: Markus Armbruster<armbru@redhat.com>  (QAPI schema)
Signed-off-by: Fiona Ebner<f.ebner@proxmox.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]