[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/13] target/i386/tcg: check for correct busy state before switch
From: |
Paolo Bonzini |
Subject: |
[PULL 09/13] target/i386/tcg: check for correct busy state before switching to a new task |
Date: |
Sun, 14 Jul 2024 13:10:39 +0200 |
This step is listed in the Intel manual: "Checks that the new task is available
(call, jump, exception, or interrupt) or busy (IRET return)".
The AMD manual lists the same operation under the "Preventing recursion"
paragraph of "12.3.4 Nesting Tasks", though it is not clear if the processor
checks the busy bit in the IRET case.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/seg_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c
index 809ee3d9833..0242f9d8b58 100644
--- a/target/i386/tcg/seg_helper.c
+++ b/target/i386/tcg/seg_helper.c
@@ -369,6 +369,11 @@ static int switch_tss_ra(CPUX86State *env, int
tss_selector,
old_tss_limit_max = 43;
}
+ /* new TSS must be busy iff the source is an IRET instruction */
+ if (!!(e2 & DESC_TSS_BUSY_MASK) != (source == SWITCH_TSS_IRET)) {
+ raise_exception_err_ra(env, EXCP0A_TSS, tss_selector & 0xfffc,
retaddr);
+ }
+
/* read all the registers from the new TSS */
if (type & 8) {
/* 32 bit */
--
2.45.2
- [PULL 00/13] target/i386 changes for 2024-07-12, Paolo Bonzini, 2024/07/14
- [PULL 03/13] target/i386/tcg: Allow IRET from user mode to user mode with SMAP, Paolo Bonzini, 2024/07/14
- [PULL 01/13] target/i386/tcg: fix POP to memory in long mode, Paolo Bonzini, 2024/07/14
- [PULL 02/13] target/i386/tcg: Remove SEG_ADDL, Paolo Bonzini, 2024/07/14
- [PULL 04/13] target/i386/tcg: use PUSHL/PUSHW for error code, Paolo Bonzini, 2024/07/14
- [PULL 05/13] target/i386/tcg: Reorg push/pop within seg_helper.c, Paolo Bonzini, 2024/07/14
- [PULL 06/13] target/i386/tcg: Introduce x86_mmu_index_{kernel_,}pl, Paolo Bonzini, 2024/07/14
- [PULL 07/13] target/i386/tcg: Compute MMU index once, Paolo Bonzini, 2024/07/14
- [PULL 08/13] target/i386/tcg: Use DPL-level accesses for interrupts and call gates, Paolo Bonzini, 2024/07/14
- [PULL 09/13] target/i386/tcg: check for correct busy state before switching to a new task,
Paolo Bonzini <=
- [PULL 10/13] target/i386/tcg: use X86Access for TSS access, Paolo Bonzini, 2024/07/14
- [PULL 11/13] target/i386/tcg: save current task state before loading new one, Paolo Bonzini, 2024/07/14
- [PULL 13/13] Revert "qemu-char: do not operate on sources from finalize callbacks", Paolo Bonzini, 2024/07/14
- [PULL 12/13] i386/sev: Don't allow automatic fallback to legacy KVM_SEV*_INIT, Paolo Bonzini, 2024/07/14
- Re: [PULL 00/13] target/i386 changes for 2024-07-12, Richard Henderson, 2024/07/14