[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 2/8] hw/pci: Fix SR-IOV VF number calculation
From: |
Akihiko Odaki |
Subject: |
[PATCH v5 2/8] hw/pci: Fix SR-IOV VF number calculation |
Date: |
Mon, 15 Jul 2024 14:19:08 +0900 |
pci_config_get_bar_addr() had a division by vf_stride. vf_stride needs
to be non-zero when there are multiple VFs, but the specification does
not prohibit to make it zero when there is only one VF.
Do not perform the division for the first VF to avoid division by zero.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/pci/pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 497a057b79f9..ae7137d70579 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1490,7 +1490,11 @@ static pcibus_t pci_config_get_bar_addr(PCIDevice *d,
int reg,
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_OFFSET);
uint16_t vf_stride =
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_STRIDE);
- uint32_t vf_num = (d->devfn - (pf->devfn + vf_offset)) / vf_stride;
+ uint32_t vf_num = d->devfn - (pf->devfn + vf_offset);
+
+ if (vf_num) {
+ vf_num /= vf_stride;
+ }
if (type & PCI_BASE_ADDRESS_MEM_TYPE_64) {
new_addr = pci_get_quad(pf->config + bar);
--
2.45.2
- [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation, Akihiko Odaki, 2024/07/15
- [PATCH v5 1/8] hw/pci: Do not add ROM BAR for SR-IOV VF, Akihiko Odaki, 2024/07/15
- [PATCH v5 4/8] pcie_sriov: Check PCI Express for SR-IOV PF, Akihiko Odaki, 2024/07/15
- [PATCH v5 2/8] hw/pci: Fix SR-IOV VF number calculation,
Akihiko Odaki <=
- [PATCH v5 5/8] pcie_sriov: Allow user to create SR-IOV device, Akihiko Odaki, 2024/07/15
- [PATCH v5 7/8] virtio-net: Implement SR-IOV VF, Akihiko Odaki, 2024/07/15
- [PATCH v5 3/8] pcie_sriov: Ensure PF and VF are mutually exclusive, Akihiko Odaki, 2024/07/15
- [PATCH v5 6/8] virtio-pci: Implement SR-IOV PF, Akihiko Odaki, 2024/07/15
- [PATCH v5 8/8] docs: Document composable SR-IOV device, Akihiko Odaki, 2024/07/15
- Re: [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation, Michael S. Tsirkin, 2024/07/30