[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64() |
|
Date: |
Mon, 15 Jul 2024 12:47:57 +0100 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Sun, Jul 14, 2024 at 02:11:02PM +0900, Akihiko Odaki wrote:
> DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO()
> as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference
> is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of
> bool.
IMHO this shouldn't be implemented in terms of On/Off auto,
as it is misleadingly accepting much more than PROP_ON_OFF
accepts. Rather it should be just DEFINE_PROP_AUTO_BIT64,
implemented in terms of 'bool', with an extra 'auto' value.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 0/5] virtio-net: Convert feature properties to OnOffAuto, Akihiko Odaki, 2024/07/14
- [PATCH v3 1/5] qdev-properties: Accept bool for OnOffAuto, Akihiko Odaki, 2024/07/14
- [PATCH v3 4/5] virtio-net: Report RSS warning at device realization, Akihiko Odaki, 2024/07/14
- [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64(), Akihiko Odaki, 2024/07/14
- Re: [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64(),
Daniel P . Berrangé <=
- [PATCH v3 3/5] virtio-net: Convert feature properties to OnOffAuto, Akihiko Odaki, 2024/07/14
- [PATCH v3 5/5] virtio-net: Remove fallback from ebpf-rss-fds, Akihiko Odaki, 2024/07/14