[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/6] python: linter changes for pylint 3.x
From: |
John Snow |
Subject: |
[PULL 1/6] python: linter changes for pylint 3.x |
Date: |
Mon, 15 Jul 2024 13:32:36 -0400 |
New bleeding edge versions, new nits to iron out. This addresses the
'check-python-tox' optional GitLab test, while 'check-python-minreqs'
saw no regressions, since it's frozen on an older version of pylint.
Fixes:
qemu/machine/machine.py:345:52: E0606: Possibly using variable 'sock' before
assignment (possibly-used-before-assignment)
qemu/utils/qemu_ga_client.py:168:4: R1711: Useless return at end of function or
method (useless-return)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20240626232230.408004-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine/machine.py | 1 +
python/qemu/utils/qemu_ga_client.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index f648f6af451..ebb58d5b68c 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -335,6 +335,7 @@ def binary(self) -> str:
def _pre_launch(self) -> None:
if self._qmp_set:
+ sock = None
if self._monitor_address is None:
self._sock_pair = socket.socketpair()
os.set_inheritable(self._sock_pair[0].fileno(), True)
diff --git a/python/qemu/utils/qemu_ga_client.py
b/python/qemu/utils/qemu_ga_client.py
index 9a665e6e990..cf0fcf9a8bb 100644
--- a/python/qemu/utils/qemu_ga_client.py
+++ b/python/qemu/utils/qemu_ga_client.py
@@ -174,7 +174,7 @@ def suspend(self, mode: str) -> None:
# On error exception will raise
except asyncio.TimeoutError:
# On success command will timed out
- return
+ pass
def shutdown(self, mode: str = 'powerdown') -> None:
if mode not in ['powerdown', 'halt', 'reboot']:
--
2.45.0
- [PULL 0/6] Python patches, John Snow, 2024/07/15
- [PULL 1/6] python: linter changes for pylint 3.x,
John Snow <=
- [PULL 2/6] python: Do not use pylint 3.2.4 with python 3.8, John Snow, 2024/07/15
- [PULL 3/6] iotests: Change imports for Python 3.13, John Snow, 2024/07/15
- [PULL 4/6] python: enable testing for 3.13, John Snow, 2024/07/15
- [PULL 5/6] Python: bump minimum sphinx version to 3.4.3, John Snow, 2024/07/15
- [PULL 6/6] docs: remove Sphinx 1.x compatibility code, John Snow, 2024/07/15
- Re: [PULL 0/6] Python patches, Richard Henderson, 2024/07/15