qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] esp.c: remove transfer size check from DMA DATA IN and DATA


From: Mark Cave-Ayland
Subject: Re: [PATCH] esp.c: remove transfer size check from DMA DATA IN and DATA OUT transfers
Date: Mon, 15 Jul 2024 23:01:55 +0100
User-agent: Mozilla Thunderbird

On 15/07/2024 07:48, Philippe Mathieu-Daudé wrote:

On 14/7/24 00:42, Mark Cave-Ayland wrote:
The transfer size check was originally added to prevent consecutive DMA TI
commands from causing an assert() due to an existing SCSI request being in
progress, but since the last set of updates

[*]

this is no longer required.

Remove the transfer size check from DMA DATA IN and DATA OUT transfers so
that issuing a DMA TI command when there is no data left to transfer does
not cause an assert() due to an existing SCSI request being in progress.


[*] See commits f3ace75be8..78d68f312a

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2415
---
  hw/scsi/esp.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Queued adding [*], thanks.

Awesome, thanks Phil!


ATB,

Mark.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]