Re: hw/display/apple-gfx

[Akihiko Odaki]

On 2024/07/16 15:38, Philippe Mathieu-Daudé wrote:
> On 16/7/24 08:07, Akihiko Odaki wrote:
> > On 2024/07/16 6:06, Phil Dennis-Jordan wrote:
> > > Date: Mon, 15 Jul 2024 21:07:12 +0200
> > > Subject: [PATCH 00/26] hw/display/apple-gfx: New macOS PV Graphics 
> > > device
> > > MIME-Version: 1.0
> > > Content-Type: text/plain; charset=UTF-8
> > > Content-Transfer-Encoding: 8bit
> > >
> > > This sequence of patches integrates the paravirtualised graphics device
> > > implemented by macOS's ParavirtualizedGraphics.Framework into Qemu.
> > > Combined with the guest drivers which ship with macOS versions 11 and 
> > > up,
> > > this allows the guest OS to use the host's GPU for hardware accelerated
> > > 3D graphics, GPGPU compute (both using the 'Metal' graphics API), and
> > > window compositing.
>
>
> > Hi,
> >
> > Thanks for continuing his effort.
>
> Yes!
>
> > Please submit a patch series that includes his patches. Please also 
> > merge fixes for his patches into them. This saves the effort to review 
> > the obsolete code and keeps git bisect working.
>
> Should be as easy as squashing patches 1-6, right?

The cover letter says:

> 04-13: These patches address issues identified during code review in
> the original e-mail threads as well as my own review.

So these patches are certainly to be squashed. There are other patches 
titled "fixes" or "refactoring", which should also be squashed. I expect 
squashing them will reduce the number of patches (and code to review) 
drastically.

Regards,
Akihiko Odaki