Re: [PATCH v2 7/9] pnv/xive2: Set Translation Table for the NVC port space

[Cédric Le Goater]

On 7/15/24 20:33, Michael Kowal wrote:
> From: Frederic Barrat <fbarrat@linux.ibm.com>
>
> Set Translation Table for the NVC port space is missing.  The xive model
> doesn't take into account the remapping of IO operations via the Set
> Translation Table but firmware is allowed to define it for the Notify
> Virtual Crowd (NVC), like it's already done for the other VST tables.
>
> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
> Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/intc/pnv_xive2.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
> index b14fad1b2e..24ecab46a1 100644
> --- a/hw/intc/pnv_xive2.c
> +++ b/hw/intc/pnv_xive2.c
> @@ -719,6 +719,7 @@ static int pnv_xive2_stt_set_data(PnvXive2 *xive, uint64_t 
> val)
>       case CQ_TAR_NVPG:
>       case CQ_TAR_ESB:
>       case CQ_TAR_END:
> +    case CQ_TAR_NVC:
>           xive->tables[tsel][entry] = val;
>           break;
>       default: