Re: [PATCH 6/6] virtio-iommu: Add trace point on virtio_iommu_detach_endpoint_from_domain

[Cédric Le Goater]

On 7/16/24 11:45, Eric Auger wrote:
> Add a trace point on virtio_iommu_detach_endpoint_from_domain().
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/virtio/virtio-iommu.c | 1 +
>   hw/virtio/trace-events   | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
> index 440dfa6e92..59ef4fb217 100644
> --- a/hw/virtio/virtio-iommu.c
> +++ b/hw/virtio/virtio-iommu.c
> @@ -308,6 +308,7 @@ static void 
> virtio_iommu_detach_endpoint_from_domain(VirtIOIOMMUEndpoint *ep)
>       if (!ep->domain) {
>           return;
>       }
> +    trace_virtio_iommu_detach_endpoint_from_domain(domain->id, ep->id);
>       g_tree_foreach(domain->mappings, virtio_iommu_notify_unmap_cb,
>                      ep->iommu_mr);
>       QLIST_REMOVE(ep, next);
> diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
> index b7c04f0856..04e36ae047 100644
> --- a/hw/virtio/trace-events
> +++ b/hw/virtio/trace-events
> @@ -116,6 +116,7 @@ virtio_iommu_get_config(uint64_t page_size_mask, uint64_t 
> start, uint64_t end, u
>   virtio_iommu_set_config(uint8_t bypass) "bypass=0x%x"
>   virtio_iommu_attach(uint32_t domain_id, uint32_t ep_id) "domain=%d 
> endpoint=%d"
>   virtio_iommu_detach(uint32_t domain_id, uint32_t ep_id) "domain=%d 
> endpoint=%d"
> +virtio_iommu_detach_endpoint_from_domain(uint32_t domain_id, uint32_t ep_id) 
> "domain=%d endpoint=%d"
>   virtio_iommu_map(uint32_t domain_id, uint64_t virt_start, uint64_t virt_end, uint64_t phys_start, uint32_t flags) 
> "domain=%d virt_start=0x%"PRIx64" virt_end=0x%"PRIx64 " phys_start=0x%"PRIx64" 
> flags=%d"
>   virtio_iommu_unmap(uint32_t domain_id, uint64_t virt_start, uint64_t virt_end) "domain=%d 
> virt_start=0x%"PRIx64" virt_end=0x%"PRIx64
>   virtio_iommu_unmap_done(uint32_t domain_id, uint64_t virt_start, uint64_t virt_end) 
> "domain=%d virt_start=0x%"PRIx64" virt_end=0x%"PRIx64