Re: [PATCH 02/11] tests/functional: Convert simple avocado tests into standalone python tests

[Daniel P . Berrangé]

On Tue, Jul 16, 2024 at 01:26:05PM +0200, Thomas Huth wrote:
> These test are rather simple and don't need any modifications apart
> from adjusting the "from avocado_qemu" line. To ease debugging, make
> the files executable and add a shebang line and Python '__main__'
> handling, too, so that these tests can now be run by executing them
> directly.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .../test_cpu_queries.py}                      |  7 ++-
>  .../test_empty_cpu_model.py}                  |  7 ++-
>  .../test_mem_addr_space.py}                   | 53 +++----------------
>  .../test_pc_cpu_hotplug_props.py}             | 11 ++--
>  .../test_virtio_version.py}                   |  8 +--
>  5 files changed, 29 insertions(+), 57 deletions(-)
>  rename tests/{avocado/cpu_queries.py => functional/test_cpu_queries.py} (89%)
>  mode change 100644 => 100755
>  rename tests/{avocado/empty_cpu_model.py => 
> functional/test_empty_cpu_model.py} (84%)
>  mode change 100644 => 100755
>  rename tests/{avocado/mem-addr-space-check.py => 
> functional/test_mem_addr_space.py} (92%)
>  mode change 100644 => 100755
>  rename tests/{avocado/pc_cpu_hotplug_props.py => 
> functional/test_pc_cpu_hotplug_props.py} (90%)
>  mode change 100644 => 100755
>  rename tests/{avocado/virtio_version.py => 
> functional/test_virtio_version.py} (98%)
>  mode change 100644 => 100755
> 

> diff --git a/tests/avocado/mem-addr-space-check.py 
> b/tests/functional/test_mem_addr_space.py
> old mode 100644
> new mode 100755
> similarity index 92%
> rename from tests/avocado/mem-addr-space-check.py
> rename to tests/functional/test_mem_addr_space.py
> index 85541ea051..bb0cf062ca
> --- a/tests/avocado/mem-addr-space-check.py
> +++ b/tests/functional/test_mem_addr_space.py
> @@ -1,3 +1,5 @@
> +#!/usr/bin/env python3
> +#
>  # Check for crash when using memory beyond the available guest processor
>  # address space.
>  #
> @@ -8,8 +10,7 @@
>  #
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  
> -from avocado_qemu import QemuSystemTest
> -import signal

Nit-pick - cleanup of an unrelated existing bug - 'signal' wasn't
used. Suggest doing it in a separate patch

Aside from that:

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|