[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/9] qapi: convert "Example" sections without titles
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 6/9] qapi: convert "Example" sections without titles |
Date: |
Wed, 17 Jul 2024 09:43:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
John Snow <jsnow@redhat.com> writes:
> Use the no-option form of ".. qmp-example::" to convert any Examples
> that do not have any form of caption or explanation whatsoever. Note
> that in a few cases, example sections are split into two or more
> separate example blocks. This is only done stylistically to create a
> delineation between two or more logically independent examples.
>
> See commit-3: "docs/qapidoc: create qmp-example directive", for a
> detailed explanation of this custom directive syntax.
>
> See commit+3: "qapi: remove "Example" doc section" for a detailed
> explanation of why.
>
> Note: an empty "TODO" line was added to announce-self to keep the
> example from floating up into the body; this will be addressed more
> rigorously in the new qapidoc generator.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
[...]
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 4d40c88876c..ab7116680b3 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
[...]
> @@ -469,7 +469,7 @@
> #
> # Since: 9.1
> #
> -# Example:
> +# ..qmp-example::
Lacks a space, output is messed up. Can fix in my tree.
> #
> # <- { "event": "GUEST_PVSHUTDOWN",
> # "timestamp": { "seconds": 1648245259, "microseconds": 893771 } }
[...]
R-by stands.
- [PATCH v2 0/9] qapi: convert example sections to qmp-example rST directives, John Snow, 2024/07/16
- [PATCH v2 1/9] [DO-NOT-MERGE]: Add some ad-hoc linting helpers., John Snow, 2024/07/16
- [PATCH v2 3/9] docs/qapidoc: create qmp-example directive, John Snow, 2024/07/16
- [PATCH v2 4/9] docs/qapidoc: add QMP highlighting to annotated qmp-example blocks, John Snow, 2024/07/16
- [PATCH v2 2/9] docs/qapidoc: factor out do_parse(), John Snow, 2024/07/16
- [PATCH v2 5/9] docs/sphinx: add CSS styling for qmp-example directive, John Snow, 2024/07/16
- [PATCH v2 6/9] qapi: convert "Example" sections without titles, John Snow, 2024/07/16
- Re: [PATCH v2 6/9] qapi: convert "Example" sections without titles,
Markus Armbruster <=
- [PATCH v2 7/9] qapi: convert "Example" sections with titles, John Snow, 2024/07/16
- [PATCH v2 8/9] qapi: convert "Example" sections with longer prose, John Snow, 2024/07/16
- [PATCH v2 9/9] qapi: remove "Example" doc section, John Snow, 2024/07/16
- Re: [PATCH v2 0/9] qapi: convert example sections to qmp-example rST directives, Markus Armbruster, 2024/07/17