[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/26] hw/vmapple/apple-gfx: BQL renaming update
From: |
Phil Dennis-Jordan |
Subject: |
[PATCH 02/26] hw/vmapple/apple-gfx: BQL renaming update |
Date: |
Mon, 15 Jul 2024 23:06:41 +0200 |
Since the original apple-gfx code was written, the BQL functions have
been renamed. This change updates the apple-gfx code to use the new
names.
Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
---
hw/vmapple/apple-gfx.m | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/vmapple/apple-gfx.m b/hw/vmapple/apple-gfx.m
index f75da5c610..3b437e2519 100644
--- a/hw/vmapple/apple-gfx.m
+++ b/hw/vmapple/apple-gfx.m
@@ -168,9 +168,9 @@ static void apple_gfx_write(void *opaque, hwaddr offset,
uint64_t val, unsigned
trace_apple_gfx_write(offset, val);
- qemu_mutex_unlock_iothread();
+ bql_unlock();
[s->pgdev mmioWriteAtOffset:offset value:val];
- qemu_mutex_lock_iothread();
+ bql_lock();
}
static const MemoryRegionOps apple_gfx_ops = {
@@ -192,9 +192,9 @@ static uint64_t apple_iosfc_read(void *opaque, hwaddr
offset, unsigned size)
AppleGFXState *s = opaque;
uint64_t res = 0;
- qemu_mutex_unlock_iothread();
+ bql_unlock();
res = [s->pgiosfc mmioReadAtOffset:offset];
- qemu_mutex_lock_iothread();
+ bql_lock();
trace_apple_iosfc_read(offset, res);
@@ -396,7 +396,7 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
PGPhysicalMemoryRange_t *range = &ranges[i];
MemoryRegion *tmp_mr;
/* TODO: Bounds checks? r/o? */
- qemu_mutex_lock_iothread();
+ bql_lock();
AppleGFXMR *mr = apple_gfx_mapMemory(s, task, virtualOffset,
range->physicalAddress,
range->physicalLength);
@@ -416,7 +416,7 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
trace_apple_gfx_remap(retval, source, target);
g_assert(retval == KERN_SUCCESS);
- qemu_mutex_unlock_iothread();
+ bql_unlock();
virtualOffset += mr->len;
}
@@ -428,7 +428,7 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
AppleGFXMR *mr, *next;
trace_apple_gfx_unmap_memory(task, virtualOffset, length);
- qemu_mutex_lock_iothread();
+ bql_lock();
QTAILQ_FOREACH_SAFE(mr, &s->mrs, node, next) {
if (mr->va >= (task->mem + virtualOffset) &&
(mr->va + mr->len) <= (task->mem + virtualOffset + length)) {
@@ -438,7 +438,7 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
g_free(mr);
}
}
- qemu_mutex_unlock_iothread();
+ bql_unlock();
return (bool)true;
};
@@ -452,13 +452,13 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
bool locked;
trace_apple_gfx_raise_irq(vector);
- locked = qemu_mutex_iothread_locked();
+ locked = bql_locked();
if (!locked) {
- qemu_mutex_lock_iothread();
+ bql_lock();
}
qemu_irq_pulse(s->irq_gfx);
if (!locked) {
- qemu_mutex_unlock_iothread();
+ bql_unlock();
}
};
@@ -534,13 +534,13 @@ static void apple_gfx_realize(DeviceState *dev, Error
**errp)
iosfc_desc.raiseInterrupt = ^(uint32_t vector) {
trace_apple_iosfc_raise_irq(vector);
- bool locked = qemu_mutex_iothread_locked();
+ bool locked = bql_locked();
if (!locked) {
- qemu_mutex_lock_iothread();
+ bql_lock();
}
qemu_irq_pulse(s->irq_iosfc);
if (!locked) {
- qemu_mutex_unlock_iothread();
+ bql_unlock();
}
return (bool)true;
};
--
2.39.3 (Apple Git-146)
- Re:, (continued)
- Re:, Phil Dennis-Jordan, 2024/07/17
- [PATCH 09/26] hw/display/apple-gfx: Wraps ObjC autorelease code in pool, Phil Dennis-Jordan, 2024/07/17
- [PATCH 10/26] hw/display/apple-gfx: Fixes ObjC new/init misuse, plugs leaks, Phil Dennis-Jordan, 2024/07/17
- [PATCH 08/26] hw/display/apple-gfx: Adds migration blocker, Phil Dennis-Jordan, 2024/07/17
- [PATCH 24/26] hw/display/apple-gfx: Adds configurable mode list, Phil Dennis-Jordan, 2024/07/17
- [PATCH 25/26] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF, Phil Dennis-Jordan, 2024/07/17
- [PATCH 21/26] hw/display/apple-gfx: Implements texture syncing for non-UMA GPUs, Phil Dennis-Jordan, 2024/07/17
- [PATCH 04/26] hw/display/apple-gfx: uses DEFINE_TYPES macro, Phil Dennis-Jordan, 2024/07/17
- [PATCH 23/26] hw/display/apple-gfx: Host GPU picking improvements, Phil Dennis-Jordan, 2024/07/17
- [PATCH 01/26] hw/vmapple/apple-gfx: Introduce ParavirtualizedGraphics.Framework support, Phil Dennis-Jordan, 2024/07/17
- [PATCH 02/26] hw/vmapple/apple-gfx: BQL renaming update,
Phil Dennis-Jordan <=
- [PATCH 05/26] hw/display/apple-gfx: native -> little endian memory ops, Phil Dennis-Jordan, 2024/07/17
- [PATCH 07/26] hw/display/apple-gfx: Makes set_mode thread & memory safe, Phil Dennis-Jordan, 2024/07/17
- [PATCH 20/26] hw/display/apple-gfx: Fixes cursor hotspot handling, Phil Dennis-Jordan, 2024/07/17
- [PATCH 06/26] hw/display/apple-gfx: Removes dead/superfluous code, Phil Dennis-Jordan, 2024/07/17
- [PATCH 17/26] hw/display/apple-gfx: Asynchronous rendering and graphics update, Phil Dennis-Jordan, 2024/07/17
- [PATCH 13/26] hw/display/apple-gfx: Defines PGTask_s struct instead of casting, Phil Dennis-Jordan, 2024/07/17
- [PATCH 16/26] hw/display/apple-gfx: Asynchronous MMIO writes on x86-64, Phil Dennis-Jordan, 2024/07/17