[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/16] hw/vfio/container: Get rid of qemu_open_old()
From: |
Michael Tokarev |
Subject: |
[PULL 12/16] hw/vfio/container: Get rid of qemu_open_old() |
Date: |
Wed, 17 Jul 2024 14:06:36 +0300 |
From: Zhao Liu <zhao1.liu@intel.com>
For qemu_open_old(), osdep.h said:
> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".
So replace qemu_open_old() with qemu_open().
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: "Cédric Le Goater" <clg@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/vfio/container.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 425db1a14c..38a9df3496 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -600,9 +600,8 @@ static bool vfio_connect_container(VFIOGroup *group,
AddressSpace *as,
}
}
- fd = qemu_open_old("/dev/vfio/vfio", O_RDWR);
+ fd = qemu_open("/dev/vfio/vfio", O_RDWR, errp);
if (fd < 0) {
- error_setg_errno(errp, errno, "failed to open /dev/vfio/vfio");
goto put_space_exit;
}
@@ -743,9 +742,8 @@ static VFIOGroup *vfio_get_group(int groupid, AddressSpace
*as, Error **errp)
group = g_malloc0(sizeof(*group));
snprintf(path, sizeof(path), "/dev/vfio/%d", groupid);
- group->fd = qemu_open_old(path, O_RDWR);
+ group->fd = qemu_open(path, O_RDWR, errp);
if (group->fd < 0) {
- error_setg_errno(errp, errno, "failed to open %s", path);
goto free_group_exit;
}
--
2.39.2
- [PULL 02/16] README.rst: add the missing punctuations, (continued)
- [PULL 02/16] README.rst: add the missing punctuations, Michael Tokarev, 2024/07/17
- [PULL 01/16] block/curl: rewrite http header parsing function, Michael Tokarev, 2024/07/17
- [PULL 03/16] accel/kvm/kvm-all: Fix superfluous trailing semicolon, Michael Tokarev, 2024/07/17
- [PULL 06/16] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon, Michael Tokarev, 2024/07/17
- [PULL 07/16] doc/net/l2tpv3: Update boolean fields' description to avoid short-form use, Michael Tokarev, 2024/07/17
- [PULL 05/16] util/oslib-posix: Fix superfluous trailing semicolon, Michael Tokarev, 2024/07/17
- [PULL 09/16] hw/i386/sgx: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- [PULL 04/16] hw/i386/x86: Fix superfluous trailing semicolon, Michael Tokarev, 2024/07/17
- [PULL 11/16] hw/usb/u2f-passthru: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- [PULL 08/16] tests/avocado: Remove the non-working virtio_check_params test, Michael Tokarev, 2024/07/17
- [PULL 12/16] hw/vfio/container: Get rid of qemu_open_old(),
Michael Tokarev <=
- [PULL 10/16] hw/usb/host-libusb: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- [PULL 16/16] meson: Update meson-buildoptions.sh, Michael Tokarev, 2024/07/17
- [PULL 13/16] backends/hostmem-epc: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- [PULL 14/16] backends/iommufd: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- [PULL 15/16] backends/rng-random: Get rid of qemu_open_old(), Michael Tokarev, 2024/07/17
- Re: [PULL 00/16] Trivial patches for 2024-07-17, Richard Henderson, 2024/07/18