Mouse cursors with 8 bit alpha were downsampled to 1-bit opacity maps by
turning alpha values of 255 into 1 and everything else into 0. This
means that mostly-opaque pixels ended up completely invisible.
This patch changes the behaviour so that only pixels with less than 50%
alpha (0-127) are treated as transparent when converted to 1-bit alpha.
This greatly improves the subjective appearance of anti-aliased mouse
cursors, such as those used by macOS, when using a front-end UI without
support for alpha-blended cursors, such as some VNC clients.
Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Thanks for the reviews folks! Is there anything I can do to move this forward? Should I submit a v3 with the review tags included? The patch continues to apply cleanly so it didn't seem necessary, but I admit I'm still not 100% clear on whom I should badger (?) to get favourably received patches actually pulled into staging/master.
Thanks!
Kind regards,
Phil