[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 09/12] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_t
|
From: |
Joao Martins |
|
Subject: |
Re: [PATCH v4 09/12] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support |
|
Date: |
Wed, 17 Jul 2024 16:18:26 +0100 |
On 17/07/2024 14:34, Eric Auger wrote:
> On 7/17/24 14:41, Joao Martins wrote:
>> On 17/07/2024 13:36, Eric Auger wrote:
>>> On 7/12/24 13:47, Joao Martins wrote:
>>>> The checking of hwpt::flags is introduced here as a second user
>>> ?? -> introduce iommufd_hwpt_dirty_tracking() helper to avoid code dup?
>> Right I am doing that already. Not sure what the problem is with this
>> sentence?
>
> "The checking of hwpt::flags is introduced here as a second user" phrasing
> sounds weird to me.
> I guess you just meant that you need to check
> hwpt::flags in another place so better off introducing an helper.
>
Exactly.
- Re: [PATCH v4 08/12] vfio/iommufd: Probe and request hwpt dirty tracking capability, (continued)
[PATCH v4 09/12] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support, Joao Martins, 2024/07/12
[PATCH v4 12/12] vfio/common: Allow disabling device dirty page tracking, Joao Martins, 2024/07/12
[PATCH v4 07/12] vfio/{iommufd, container}: Initialize HostIOMMUDeviceCaps during attach_device(), Joao Martins, 2024/07/12
- Re: [PATCH v4 07/12] vfio/{iommufd,container}: Initialize HostIOMMUDeviceCaps during attach_device(), Cédric Le Goater, 2024/07/16
- RE: [PATCH v4 07/12] vfio/{iommufd,container}: Initialize HostIOMMUDeviceCaps during attach_device(), Duan, Zhenzhong, 2024/07/16
- Re: [PATCH v4 07/12] vfio/{iommufd,container}: Initialize HostIOMMUDeviceCaps during attach_device(), Eric Auger, 2024/07/17