[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] arm/virt: place power button pin number on a define
|
From: |
Jonathan Cameron |
|
Subject: |
Re: [PATCH v2 1/7] arm/virt: place power button pin number on a define |
|
Date: |
Wed, 17 Jul 2024 16:34:42 +0100 |
On Fri, 12 Jul 2024 15:15:08 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> Having magic numbers inside the code is not a good idea, as it
> is error-prone. So, instead, create a macro with the number
> definition.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Seems sensible to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
- [PATCH v2 0/7] Add ACPI CPER firmware first error injection for Arm Processor, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 6/7] acpi/ghes: update comments to point to newer ACPI specs, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 1/7] arm/virt: place power button pin number on a define, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 2/7] arm/virt: Wire up GPIO error source for ACPI / GHES, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 3/7] acpi/ghes: Support GPIO error source., Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 5/7] target/arm: preserve mpidr value, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 7/7] acpi/ghes: extend arm error injection logic, Mauro Carvalho Chehab, 2024/07/12
- [PATCH v2 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection, Mauro Carvalho Chehab, 2024/07/12