[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 04/12] target/ppc/mem_helper.c: Remove a conditional from dcbz
From: |
Richard Henderson |
Subject: |
[PATCH v3 04/12] target/ppc/mem_helper.c: Remove a conditional from dcbz_common() |
Date: |
Fri, 19 Jul 2024 11:06:59 +1000 |
From: BALATON Zoltan <balaton@eik.bme.hu>
Instead of passing a bool and select a value within dcbz_common() let
the callers pass in the right value to avoid this conditional
statement. On PPC dcbz is often used to zero memory and some code uses
it a lot. This change improves the run time of a test case that copies
memory with a dcbz call in every iteration from 6.23 to 5.83 seconds.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20240622204833.5F7C74E6000@zero.eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
---
target/ppc/mem_helper.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c
index f88155ad45..361fd72226 100644
--- a/target/ppc/mem_helper.c
+++ b/target/ppc/mem_helper.c
@@ -271,12 +271,11 @@ void helper_stsw(CPUPPCState *env, target_ulong addr,
uint32_t nb,
}
static void dcbz_common(CPUPPCState *env, target_ulong addr,
- uint32_t opcode, bool epid, uintptr_t retaddr)
+ uint32_t opcode, int mmu_idx, uintptr_t retaddr)
{
target_ulong mask, dcbz_size = env->dcache_line_size;
uint32_t i;
void *haddr;
- int mmu_idx = epid ? PPC_TLB_EPID_STORE : ppc_env_mmu_index(env, false);
#if defined(TARGET_PPC64)
/* Check for dcbz vs dcbzl on 970 */
@@ -309,12 +308,12 @@ static void dcbz_common(CPUPPCState *env, target_ulong
addr,
void helper_dcbz(CPUPPCState *env, target_ulong addr, uint32_t opcode)
{
- dcbz_common(env, addr, opcode, false, GETPC());
+ dcbz_common(env, addr, opcode, ppc_env_mmu_index(env, false), GETPC());
}
void helper_dcbzep(CPUPPCState *env, target_ulong addr, uint32_t opcode)
{
- dcbz_common(env, addr, opcode, true, GETPC());
+ dcbz_common(env, addr, opcode, PPC_TLB_EPID_STORE, GETPC());
}
void helper_icbi(CPUPPCState *env, target_ulong addr)
--
2.43.0
- [PATCH v3 01/12] accel/tcg: Move {set, clear}_helper_retaddr to cpu_ldst.h, (continued)
- [PATCH v3 01/12] accel/tcg: Move {set, clear}_helper_retaddr to cpu_ldst.h, Richard Henderson, 2024/07/18
- [PATCH v3 03/12] target/arm: Use set/clear_helper_retaddr in SVE and SME helpers, Richard Henderson, 2024/07/18
- [PATCH v3 02/12] target/arm: Use set/clear_helper_retaddr in helper-a64.c, Richard Henderson, 2024/07/18
- [PATCH v3 05/12] target/ppc: Hoist dcbz_size out of dcbz_common, Richard Henderson, 2024/07/18
- [PATCH v3 06/12] target/ppc: Split out helper_dbczl for 970, Richard Henderson, 2024/07/18
- [PATCH v3 09/12] target/s390x: Use user_or_likely in do_access_memset, Richard Henderson, 2024/07/18
- [PATCH v3 07/12] target/ppc: Merge helper_{dcbz,dcbzep}, Richard Henderson, 2024/07/18
- [PATCH v3 08/12] target/ppc: Improve helper_dcbz for user-only, Richard Henderson, 2024/07/18
- [PATCH v3 04/12] target/ppc/mem_helper.c: Remove a conditional from dcbz_common(),
Richard Henderson <=
- [PATCH v3 12/12] target/riscv: Simplify probing in vext_ldff, Richard Henderson, 2024/07/18
- [PATCH v3 10/12] target/s390x: Use user_or_likely in access_memmove, Richard Henderson, 2024/07/18
- [PATCH v3 11/12] target/s390x: Use set/clear_helper_retaddr in mem_helper.c, Richard Henderson, 2024/07/18