[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 56/63] tests/qtest/bios-tables-test.c: Remove the fall back path
From: |
Michael S. Tsirkin |
Subject: |
[PULL 56/63] tests/qtest/bios-tables-test.c: Remove the fall back path |
Date: |
Sun, 21 Jul 2024 20:18:49 -0400 |
From: Sunil V L <sunilvl@ventanamicro.com>
The expected ACPI AML files are moved now under ${arch}/{machine} path.
Hence, there is no need to search in old path which didn't have ${arch}.
Remove the code which searches for the expected AML files under old path
as well.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20240716144306.2432257-7-sunilvl@ventanamicro.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/bios-tables-test.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index f4c4704bab..498e0e35d9 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -267,15 +267,6 @@ static void dump_aml_files(test_data *data, bool rebuild)
data->arch, data->machine,
sdt->aml, ext);
- /*
- * To keep test cases not failing before the DATA files are moved
to
- * ${arch}/${machine} folder, add this check as well.
- */
- if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
- aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir,
- data->machine, sdt->aml, ext);
- }
-
if (!g_file_test(aml_file, G_FILE_TEST_EXISTS) &&
sdt->aml_len == exp_sdt->aml_len &&
!memcmp(sdt->aml, exp_sdt->aml, sdt->aml_len)) {
@@ -412,11 +403,6 @@ static GArray *load_expected_aml(test_data *data)
try_again:
aml_file = g_strdup_printf("%s/%s/%s/%.4s%s", data_dir, data->arch,
data->machine, sdt->aml, ext);
- if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
- aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir, data->machine,
- sdt->aml, ext);
- }
-
if (verbosity_level >= 2) {
fprintf(stderr, "Looking for expected file '%s'\n", aml_file);
}
--
MST
- [PULL 48/63] virtio-iommu: Remove the end point on detach, (continued)
- [PULL 48/63] virtio-iommu: Remove the end point on detach, Michael S. Tsirkin, 2024/07/21
- [PULL 61/63] backends: Initial support for SPDM socket support, Michael S. Tsirkin, 2024/07/21
- [PULL 54/63] acpi/gpex: Create PCI link devices outside PCI root bridge, Michael S. Tsirkin, 2024/07/21
- [PULL 53/63] tests/acpi: Allow DSDT acpi table changes for aarch64, Michael S. Tsirkin, 2024/07/21
- [PULL 58/63] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V, Michael S. Tsirkin, 2024/07/21
- [PULL 60/63] hw/pci: Add all Data Object Types defined in PCIe r6.0, Michael S. Tsirkin, 2024/07/21
- [PULL 59/63] tests/acpi: Add expected ACPI AML files for RISC-V, Michael S. Tsirkin, 2024/07/21
- [PULL 63/63] virtio: Always reset vhost devices, Michael S. Tsirkin, 2024/07/21
- [PULL 57/63] tests/acpi: Add empty ACPI data files for RISC-V, Michael S. Tsirkin, 2024/07/21
- [PULL 62/63] hw/nvme: Add SPDM over DOE support, Michael S. Tsirkin, 2024/07/21
- [PULL 56/63] tests/qtest/bios-tables-test.c: Remove the fall back path,
Michael S. Tsirkin <=
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Richard Henderson, 2024/07/22
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Michael S. Tsirkin, 2024/07/22
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Richard Henderson, 2024/07/22
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Michael S. Tsirkin, 2024/07/23
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Hanna Czenczek, 2024/07/23
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Michael S. Tsirkin, 2024/07/23
- Re: [PULL 00/63] virtio,pci,pc: features,fixes, Hanna Czenczek, 2024/07/23