Re: [PATCH 07/13] qtest/fuzz: make range overlap check more readable

[Alexander Bulekov]

On 240722 0007, Yao Xingtao wrote:
> use ranges_overlap() instead of open-coding the overlap check to improve
> the readability of the code.
> 
> Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>

Reviewed-by: Alexander Bulekov <alxndr@bu.edu>

Thank you

> ---
>  tests/qtest/fuzz/generic_fuzz.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index ec842e03c5e6..d107a496da63 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -11,6 +11,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/range.h"
>  
>  #include <wordexp.h>
>  
> @@ -211,7 +212,7 @@ void fuzz_dma_read_cb(size_t addr, size_t len, 
> MemoryRegion *mr)
>           i < dma_regions->len && (avoid_double_fetches || qtest_log_enabled);
>           ++i) {
>          region = g_array_index(dma_regions, address_range, i);
> -        if (addr < region.addr + region.size && addr + len > region.addr) {
> +        if (ranges_overlap(addr, len, region.addr, region.size)) {
>              double_fetch = true;
>              if (addr < region.addr
>                  && avoid_double_fetches) {
> -- 
> 2.41.0
>