[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] hpet: remove unnecessary variable "index"
From: |
Paolo Bonzini |
Subject: |
[PATCH 3/7] hpet: remove unnecessary variable "index" |
Date: |
Mon, 22 Jul 2024 14:05:37 +0200 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/timer/hpet.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index bbb1e5f0897..380e272fbeb 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -437,12 +437,12 @@ static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
unsigned size)
{
HPETState *s = opaque;
- uint64_t cur_tick, index;
+ uint64_t cur_tick;
trace_hpet_ram_read(addr);
- index = addr;
+
/*address range of all TN regs*/
- if (index >= 0x100 && index <= 0x3ff) {
+ if (addr >= 0x100 && addr <= 0x3ff) {
uint8_t timer_id = (addr - 0x100) / 0x20;
HPETTimer *timer = &s->timer[timer_id];
@@ -469,7 +469,7 @@ static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
break;
}
} else {
- switch (index) {
+ switch (addr) {
case HPET_ID:
return s->capability;
case HPET_PERIOD:
@@ -510,15 +510,14 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
{
int i;
HPETState *s = opaque;
- uint64_t old_val, new_val, val, index;
+ uint64_t old_val, new_val, val;
trace_hpet_ram_write(addr, value);
- index = addr;
old_val = hpet_ram_read(opaque, addr, 4);
new_val = value;
/*address range of all TN regs*/
- if (index >= 0x100 && index <= 0x3ff) {
+ if (addr >= 0x100 && addr <= 0x3ff) {
uint8_t timer_id = (addr - 0x100) / 0x20;
HPETTimer *timer = &s->timer[timer_id];
@@ -620,7 +619,7 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
}
return;
} else {
- switch (index) {
+ switch (addr) {
case HPET_ID:
return;
case HPET_CFG:
--
2.45.2
- [PATCH 0/7] hpet: fixes for 64-bit mode and interrupt status registers, Paolo Bonzini, 2024/07/22
- [PATCH 1/7] hpet: fix and cleanup persistence of interrupt status, Paolo Bonzini, 2024/07/22
- [PATCH 3/7] hpet: remove unnecessary variable "index",
Paolo Bonzini <=
- [PATCH 4/7] hpet: place read-only bits directly in "new_val", Paolo Bonzini, 2024/07/22
- [PATCH 7/7] hpet: avoid timer storms on periodic timers, Paolo Bonzini, 2024/07/22
- [PATCH 2/7] hpet: ignore high bits of comparator in 32-bit mode, Paolo Bonzini, 2024/07/22
- [PATCH 5/7] hpet: accept 64-bit reads and writes, Paolo Bonzini, 2024/07/22
- [PATCH 6/7] hpet: store full 64-bit target value of the counter, Paolo Bonzini, 2024/07/22