qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] crypto: drop gnutls debug logging support


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/5] crypto: drop gnutls debug logging support
Date: Mon, 22 Jul 2024 16:32:23 +0200
User-agent: Mozilla Thunderbird

On 22/7/24 15:16, Daniel P. Berrangé wrote:
GNUTLS already supports dynamically enabling its logging at runtime by
setting the env var 'GNUTLS_DEBUG_LEVEL=10', so there is no need to
re-invent this logic in QEMU in a way that requires a re-compile.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  crypto/init.c | 11 -----------
  1 file changed, 11 deletions(-)

diff --git a/crypto/init.c b/crypto/init.c
index fb7f1bff10..2d6dfa3091 100644
--- a/crypto/init.c
+++ b/crypto/init.c
@@ -34,13 +34,6 @@
#include "crypto/random.h" -/* #define DEBUG_GNUTLS */

Maybe mention GNUTLS_DEBUG_LEVEL=10 here or in header? Otherwise

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]