Re: [RFC PATCH v2 9/9] migration/multifd: Replace multifd_send_state->pages with client data

[Peter Xu]

On Mon, Jul 22, 2024 at 05:26:49PM -0300, Fabiano Rosas wrote:
> >> +void multifd_ram_save_setup(void)
> >> +{
> >> +    uint32_t n = MULTIFD_PACKET_SIZE / qemu_target_page_size();
> >> +
> >> +    multifd_ram_send = multifd_send_data_alloc();
> >> +    multifd_ram_send->u.ram.allocated = n;
> >
> > IIUC this line won't help, as the type is still NONE.. We may need to reset
> > this in multifd_pages_reset() even if it's a constant to RAM code.
> 
> I could maybe just hardcode it in the packet. No point setting this
> every time.

Yeah sounds ok.  As long as this keeps working after VFIO can reuse this
object at some point (and overwrite "allocate"), then it looks fine by me.

-- 
Peter Xu