[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] meson: build chardev trace files when have_block
From: |
Daniel P . Berrangé |
Subject: |
[PATCH] meson: build chardev trace files when have_block |
Date: |
Tue, 23 Jul 2024 11:35:42 +0100 |
The QSD depends on chardev code, and is built when have_tools is
true. This means conditionalizing chardev trace on have_system
is wrong, we need have_block which is set have_system || have_tools.
This latent bug was historically harmless because only the spice
chardev included tracing, which wasn't built in a !have_system
scenario.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This is an add-on needed for:
https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05068.html
since I discovered a tools-only build fails
diff --git a/meson.build b/meson.build
index a1e51277b0..d3850a8c0f 100644
--- a/meson.build
+++ b/meson.build
@@ -3327,6 +3327,7 @@ if have_block
trace_events_subdirs += [
'authz',
'block',
+ 'chardev',
'io',
'nbd',
'scsi',
@@ -3338,7 +3339,6 @@ if have_system
'audio',
'backends',
'backends/tpm',
- 'chardev',
'ebpf',
'hw/9pfs',
'hw/acpi',
--
2.45.2
- [PATCH] meson: build chardev trace files when have_block,
Daniel P . Berrangé <=