Re: [PATCH] docs/devel: update tcg-plugins page

[Pierrick Bouvier]

On 7/23/24 13:59, Philippe Mathieu-Daudé wrote:
> On 23/7/24 22:54, Pierrick Bouvier wrote:
> > Reflect recent changes on API (inline ops) and new plugins.
> >
> > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> > ---
> >    docs/devel/tcg-plugins.rst | 101 +++++++++++++++++++++++--------------
> >    1 file changed, 63 insertions(+), 38 deletions(-)
>
>
> >      $QEMU $OTHER_QEMU_ARGS \
> > -      -plugin contrib/plugin/libhowvec.so,inline=on,count=hint \
> > -      -plugin contrib/plugin/libhotblocks.so
> > +      -plugin contrib/plugins/libhowvec.so,inline=on,count=hint \
> > +      -plugin contrib/plugins/libhotblocks.so
>
>
> > -- tests/plugins/empty.c
> > +- tests/plugin/empty.c
>
>
> Could we use the same directory name for contrib/ and tests/
> to avoid that kind of confusion?

I agree with that, but it's out of the scope for this simple patch (just 
want to update doc for 9.1 release that is coming). That said:

A thing that as been asked some time ago was to build contrib plugins 
using meson too.
(see: https://gitlab.com/qemu-project/qemu/-/issues/1710).
I see that as a good opportunity to solve both issues, by keeping all 
plugins in a single folder (tests/plugin), eventually with 
tests/plugin/contrib if preferred.

Updating API with the contrib folder being built with a makefile is a 
pain, and some target arch have warnings when building them, so it would 
be a good move. And people can still build them out of tree manually if 
they want. Plus, those plugins would run in CI, so they would be more 
robust.

@Alex: would you be keen to see those changes (for 9.2)?
I'm keen to make it, and fix all warnings, as soon as we agree where to 
move those nice little plugins.