[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab-ci: Use -fno-sanitize=function in the clang-user job
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH] gitlab-ci: Use -fno-sanitize=function in the clang-user job |
|
Date: |
Wed, 24 Jul 2024 08:08:35 +0200 |
|
User-agent: |
Mozilla Thunderbird |
On 24/07/2024 01.25, Richard Henderson wrote:
With -fsanitize=undefined, which implies -fsanitize=function,
clang will add a "type signature" before functions.
It accesses funcptr-8 and funcptr-4 to do so.
The generated TCG prologue is directly on a page boundary,
so these accesses segfault.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
What happend to Akihiko Odaki's more generic patch:
20240714-function-v1-1-cc2acb4171ba@daynix.com/">https://lore.kernel.org/qemu-devel/20240714-function-v1-1-cc2acb4171ba@daynix.com/
?
Paolo, you mentioned that you'd queue it, did this patch fell through the
cracks?
Does anyone know why we're using --extra-cflags for the clang-user
and clang-system jobs, as opposed to --enable-sanitizers?
I don't remember, but it was likely the -fno-sanitize-recover=undefined I guess.
It
certainly seems like regular users who use the normal configure
flag are going to run into this as well.
Yes, we should merge Akihiko Odaki's patch for this reason.
Thomas