qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/rx: Use target_ulong for address in LI


From: Thomas Huth
Subject: Re: [PATCH] target/rx: Use target_ulong for address in LI
Date: Wed, 24 Jul 2024 08:15:06 +0200
User-agent: Mozilla Thunderbird

On 24/07/2024 06.56, Richard Henderson wrote:
Using int32_t meant that the address was sign-extended to uint64_t
when passing to translator_ld*, triggering an assert.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2453
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/rx/translate.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/rx/translate.c b/target/rx/translate.c
index 9b81cf20b3..9aade2b6e5 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -85,7 +85,8 @@ static uint32_t decode_load_bytes(DisasContext *ctx, uint32_t 
insn,
static uint32_t li(DisasContext *ctx, int sz)
  {
-    int32_t tmp, addr;
+    target_ulong addr;
+    uint32_t tmp;
      CPURXState *env = ctx->env;
      addr = ctx->base.pc_next;

Thank you very much! This fixes the problem for me.

Tested-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]