Re: [PATCH v5 1/5] target/ppc: reduce code duplication across Power9/10 init code

[Aditya Gupta]

Hi Nick,

On 23/07/24 10:52, Nicholas Piggin wrote:
> > <...snip...>
> >
> > +    PCR_COMPAT_3_00 | PCR_COMPAT_2_07 | PCR_COMPAT_2_06 | PCR_COMPAT_2_05
> > +#define POWERPC_POWER10_PCC_PCR_SUPPORTED \
> > +    POWERPC_POWER9_PCC_PCR_SUPPORTED | PCR_COMPAT_3_10
> > +#define POWERPC_POWER9_PCC_LPCR_MASK                                        \
> > +    LPCR_VPM1 | LPCR_ISL | LPCR_KBV | LPCR_DPFD |                           \
> > +    (LPCR_PECE_U_MASK & LPCR_HVEE) | LPCR_ILE | LPCR_AIL |                  \
> > +    LPCR_UPRT | LPCR_EVIRT | LPCR_ONL | LPCR_HR | LPCR_LD |                 \
> > +    (LPCR_PECE_L_MASK & (LPCR_PDEE|LPCR_HDEE|LPCR_EEE|LPCR_DEE|LPCR_OEE)) | \
> > +    LPCR_MER | LPCR_GTSE | LPCR_TC | LPCR_HEIC | LPCR_LPES0 | LPCR_HVICE |  \
> > +    LPCR_HDICE
> > +/* DD2 adds an extra HAIL bit */
> > +#define POWERPC_POWER10_PCC_LPCR_MASK \
> > +    POWERPC_POWER9_PCC_LPCR_MASK | LPCR_HAIL
> > +#define POWERPC_POWER9_PCC_FLAGS_COMMON                                 \
> POWERPC_FLAG_POWER9

Can we keep PPC_FLAG_POWER9 here ?

Like if all PowerPC flags start with PPC_* ?


Thanks,

Aditya Gupta

> > +    POWERPC_FLAG_VRE | POWERPC_FLAG_SE | POWERPC_FLAG_BE |              \
> > +    POWERPC_FLAG_PMM | POWERPC_FLAG_BUS_CLK | POWERPC_FLAG_CFAR |       \
> > +    POWERPC_FLAG_VSX | POWERPC_FLAG_SCV
> > +
> > +#define POWERPC_POWER9_PCC_FLAGS  \
> > +    POWERPC_POWER9_PCC_FLAGS_COMMON | POWERPC_FLAG_TM
> > +#define POWERPC_POWER10_PCC_FLAGS \
> > +    POWERPC_POWER9_PCC_FLAGS_COMMON | POWERPC_FLAG_BHRB
> > +
> > +#endif /* TARGET_PPC_CPU_INIT_H */