[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/11] pnv/xive2: Fail VST entry address computation if table
From: |
Michael Kowal |
Subject: |
[PATCH v4 08/11] pnv/xive2: Fail VST entry address computation if table has no VSD |
Date: |
Wed, 24 Jul 2024 16:21:27 -0500 |
From: Frederic Barrat <fbarrat@linux.ibm.com>
Fail VST entry address computation if firmware doesn't define a descriptor
for one of the Virtualization Structure Tables (VST), there's no point in
trying to compute the address of its entry. Abort the operation and log
an error.
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
---
hw/intc/pnv_xive2.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
index dab4c169a4..9fe3ec9a67 100644
--- a/hw/intc/pnv_xive2.c
+++ b/hw/intc/pnv_xive2.c
@@ -244,6 +244,11 @@ static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive,
uint32_t type, uint8_t blk,
}
vsd = xive->vsds[type][blk];
+ if (vsd == 0) {
+ xive2_error(xive, "VST: vsd == 0 block id %d for VST %s %d !?",
+ blk, info->name, idx);
+ return 0;
+ }
/* Remote VST access */
if (GETFIELD(VSD_MODE, vsd) == VSD_MODE_FORWARD) {
--
2.43.0
- [PATCH v4 06/11] pnv/xive2: Enable VST NVG and NVC index compression, (continued)
- [PATCH v4 06/11] pnv/xive2: Enable VST NVG and NVC index compression, Michael Kowal, 2024/07/24
- [PATCH v4 03/11] pnv/xive: Support cache flush and queue sync inject with notifications, Michael Kowal, 2024/07/24
- [PATCH v4 04/11] pnv/xive2: Add NVG and NVC to cache watch facility, Michael Kowal, 2024/07/24
- [PATCH v4 09/11] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c, Michael Kowal, 2024/07/24
- [PATCH v4 02/11] pnv/xive2: Structure/define alignment changes, Michael Kowal, 2024/07/24
- [PATCH v4 01/11] pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support, Michael Kowal, 2024/07/24
- [PATCH v4 05/11] pnv/xive2: Configure Virtualization Structure Tables through the PC, Michael Kowal, 2024/07/24
- [PATCH v4 10/11] pnv/xive2: Refine TIMA 'info pic' output, Michael Kowal, 2024/07/24
- [PATCH v4 08/11] pnv/xive2: Fail VST entry address computation if table has no VSD,
Michael Kowal <=
- [PATCH v4 11/11] pnv/xive2: Dump more END state with 'info pic', Michael Kowal, 2024/07/24