qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/23] tests/functional: Convert simple avocado tests into


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 05/23] tests/functional: Convert simple avocado tests into standalone python tests
Date: Thu, 25 Jul 2024 13:56:32 +0200
User-agent: Mozilla Thunderbird

On 25/7/24 08:55, Philippe Mathieu-Daudé wrote:
Hi Thomas,

On 24/7/24 19:52, Thomas Huth wrote:
These test are rather simple and don't need any modifications apart
from adjusting the "from avocado_qemu" line. To ease debugging, make
the files executable and add a shebang line and Python '__main__'
handling, too, so that these tests can now be run by executing them
directly.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  tests/functional/meson.build                  |  5 ++
  .../test_cpu_queries.py}                      |  7 ++-
  .../test_empty_cpu_model.py}                  |  7 ++-
  .../test_mem_addr_space.py}                   | 52 +++----------------
  .../test_pc_cpu_hotplug_props.py}             | 11 ++--
  .../test_virtio_version.py}                   |  8 +--
  6 files changed, 34 insertions(+), 56 deletions(-)
  rename tests/{avocado/cpu_queries.py => functional/test_cpu_queries.py} (89%)
  mode change 100644 => 100755
  rename tests/{avocado/empty_cpu_model.py => functional/test_empty_cpu_model.py} (84%)
  mode change 100644 => 100755
  rename tests/{avocado/mem-addr-space-check.py => functional/test_mem_addr_space.py} (93%)
  mode change 100644 => 100755
  rename tests/{avocado/pc_cpu_hotplug_props.py => functional/test_pc_cpu_hotplug_props.py} (90%)
  mode change 100644 => 100755
  rename tests/{avocado/virtio_version.py => functional/test_virtio_version.py} (98%)
  mode change 100644 => 100755


@@ -22,9 +24,6 @@ class MemAddrCheck(QemuSystemTest):
      # for all 32-bit cases, pci64_hole_size is 0.
      def test_phybits_low_pse36(self):
          """
-        :avocado: tags=machine:q35
-        :avocado: tags=arch:x86_64

Could we keep the tags, but renaming as:

           qemu-test-tag=machine:q35
           qemu-test-tag=arch:x86_64

?

Bah, let's just remove that for now, since this feature implementation
might use a different format.


I'm OK to implement the equivalent feature in QEMU functional framework.

          With pse36 feature ON, a processor has 36 bits of addressing. So it can           access up to a maximum of 64GiB of memory. Memory hotplug region begins           at 4 GiB boundary when "above_4g_mem_size" is 0 (this would be true when





reply via email to

[Prev in Thread] Current Thread [Next in Thread]