[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] target/i386: Clean output of vmsr_read_thread_stat()
From: |
Anthony Harivel |
Subject: |
[PATCH 2/2] target/i386: Clean output of vmsr_read_thread_stat() |
Date: |
Fri, 26 Jul 2024 12:26:32 +0200 |
Fix leaking memory of file handle in case of error
Erase unused "pid = -1"
Add clearer error_report
Should fix: CID 1558557
Signed-off-by: Anthony Harivel <aharivel@redhat.com>
---
target/i386/kvm/vmsr_energy.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/i386/kvm/vmsr_energy.c b/target/i386/kvm/vmsr_energy.c
index a1d78f2f2aee..7e064c5aef30 100644
--- a/target/i386/kvm/vmsr_energy.c
+++ b/target/i386/kvm/vmsr_energy.c
@@ -270,7 +270,7 @@ void vmsr_read_thread_stat(pid_t pid,
FILE *file = fopen(path, "r");
if (file == NULL) {
- pid = -1;
+ error_report("Error opening %s", path_name);
return;
}
@@ -279,7 +279,8 @@ void vmsr_read_thread_stat(pid_t pid,
" %*u %*u %*u %*u %*u %*u %*u %*u %*u %*d %*u %*u %u",
utime, stime, cpu_id) != 3)
{
- pid = -1;
+ fclose(file);
+ error_report("Error fscanf did not report the right amount of items");
return;
}
--
2.45.2