[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/14] tests/avocado: test_arm_emcraft_sf2: handle RW requirements
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 14/14] tests/avocado: test_arm_emcraft_sf2: handle RW requirements for asset |
Date: |
Mon, 29 Jul 2024 17:27:14 +0200 |
From: Cleber Rosa <crosa@redhat.com>
The asset used in the mentioned test gets truncated before it's used
in the test. This means that the file gets modified, and thus the
asset's expected hash doesn't match anymore. This causes cache misses
and re-downloads every time the test is re-run.
Let's make a copy of the asset so that the one in the cache is
preserved and the cache sees a hit on re-runs.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240726134438.14720-9-crosa@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/avocado/boot_linux_console.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/avocado/boot_linux_console.py
b/tests/avocado/boot_linux_console.py
index b8b0a4df10..2929aa042d 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -401,14 +401,16 @@ def test_arm_emcraft_sf2(self):
'fe371d32e50ca682391e1e70ab98c2942aeffb01/spi.bin')
spi_hash = '65523a1835949b6f4553be96dec1b6a38fb05501'
spi_path = self.fetch_asset(spi_url, asset_hash=spi_hash)
+ spi_path_rw = os.path.join(self.workdir, os.path.basename(spi_path))
+ shutil.copy(spi_path, spi_path_rw)
- file_truncate(spi_path, 16 << 20) # Spansion S25FL128SDPBHICO is 16 MiB
+ file_truncate(spi_path_rw, 16 << 20) # Spansion S25FL128SDPBHICO is 16
MiB
self.vm.set_console()
kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE
self.vm.add_args('-kernel', uboot_path,
'-append', kernel_command_line,
- '-drive', 'file=' + spi_path + ',if=mtd,format=raw',
+ '-drive', 'file=' + spi_path_rw +
',if=mtd,format=raw',
'-no-reboot')
self.vm.launch()
self.wait_for_console_pattern('Enter \'help\' for a list')
--
2.45.2
- [PULL 04/14] tests/functional: Add base classes for the upcoming pytest-based tests, (continued)
- [PULL 04/14] tests/functional: Add base classes for the upcoming pytest-based tests, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 05/14] tests/Makefile.include: Increase the level of indentation in the help text, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 06/14] tests/functional: Prepare the meson build system for the functional tests, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 08/14] tests/functional: Convert avocado tests that just need a small adjustment, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 07/14] tests/functional: Convert simple avocado tests into standalone python tests, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 09/14] tests/functional: Convert the x86_cpu_model_versions test, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 10/14] tests/functional: Convert the riscv_opensbi avocado test into a standalone test, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 11/14] gitlab-ci: Add "check-functional" to the build tests, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 12/14] tests/avocado: mips: fallback to HTTP given certificate expiration, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 13/14] tests/avocado: mips: add hint for fetchasset plugin, Philippe Mathieu-Daudé, 2024/07/29
- [PULL 14/14] tests/avocado: test_arm_emcraft_sf2: handle RW requirements for asset,
Philippe Mathieu-Daudé <=
- Re: [PULL 00/14] Docs / testing patches for 2024-07-29, Daniel P . Berrangé, 2024/07/29